Avoid old-style casts - #405
Merged
Merged
Conversation
Replace C-style casts with static_cast/const_cast so -Wold-style-cast is clean, and enable that warning in the Unix test builds and the amalgamated-header CI job.
11 tasks
lemire
added a commit
to simdjson/simdjson
that referenced
this pull request
Aug 20, 2026
Re-vendor the amalgamated header from fastfloat/fast_float#405 so the checkperf job's -Werror=old-style-cast build succeeds. The vendor script now also accepts --from-file for an amalgamated header that is not yet a GitHub release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace C-style casts with
static_cast/const_castso-Wold-style-castis clean.Unix test targets now compile with
-Wold-style-cast(already under-Werror). The amalgamated-header CI job also buildsstring_test.cppwith-Werror=old-style-cast.This is the same class of warning that currently breaks simdjson's checkperf job when it vendors
fast_float.h.